Zidras / DBM-Warmane

DBM for Warmane (Icecrown, Lordaeron, Frostmourne, Onyxia)
https://discord.gg/CyVWDWS
152 stars 71 forks source link

[BUG] Battleground health frame shows wrong values #212

Closed emv33 closed 1 month ago

emv33 commented 2 months ago

Are you using the latest DBM version in a Warmane 3.3.5a realm (Icecrown, Lordaeron or Frostmourne)?

DBM version

10.1.12 2024/06/23 23:11:48

Current Behavior

The health frame that opens in battlegrounds like sota or ioc never shows the correct values. For instance a door that is being demolished shows 100%, and then if it breaks maybe you'll get to 0%, or maybe not.

Boss health is erratic, too. It would alternate between 100.0% (not sure why doors have no decimals whilst bosses do) and something like -1.$%, then after a wipe it wouldn't reset to 100.0%

Expected Behavior

.

Steps To Reproduce

.

Transcriptor log

.

Anything else?

No response

Error log

No response

Zidras commented 2 months ago

@emv33 , gate health is unfortunately dependent on vehicle's DBM, not your own. The player only receives comms within battleground if the vehicle player is running my DBM to properly track gate damage, since the event only shows for vehicle owner.

As for boss health, can you please send me a Transcriptor Log? I can't debug this without that information. Thank you

emv33 commented 2 months ago

Can't you get gate health from combat log?

emv33 commented 2 months ago

More comments:

1) Gate list is unordered. Should be ordered somehow.

2) Joined AV and for some reason the list comes up as empty. Should not show the frame at all if there's nothing to show I think?

image

Zidras commented 2 months ago

Can't you get gate health from combat log?

Sadly no. Only way to see gate hp afaik is in the tooltip (which is not implemented in dbm). I calculate gate timers based on damage done by vehicle and broadcasted by vehicle dbm (which most pvp players don't have)

emv33 commented 2 months ago

How does MSBT see siege damage then? Is the event only sent to the player who damages the gate?

Zidras commented 2 months ago

How does MSBT see siege damage then? Is the event only sent to the player who damages the gate?

Correct

emv33 commented 2 months ago

image

Zidras commented 1 month ago

@emv33 , have you been able to get a Transcriptor log as requested?

emv33 commented 1 month ago

Sorry, I don't intend to do that. Thanks for your time.