search

ZieIony / Carbon

Material Design implementation for Android 4.0+. Shadows, ripples, vectors, fonts, animations, widgets, rounded corners and more.
https://androidreclib.wordpress.com/
Apache License 2.0
3.05k stars 376 forks source link

Velocity absorbtion effect for scrollable views #229

Closed ZieIony closed 5 years ago

ZieIony commented 8 years ago

done

Teja-Konjeti commented 8 years ago

I'm getting NullPointerException for topGlow on absorption and no EdgeEffect when there is no background. You forgot to Initialize EdgeEffect's...

ZieIony commented 8 years ago

That's what happens after releasing asap :) Will fix.

Teja-Konjeti commented 8 years ago

Hehe..

Teja-Konjeti commented 8 years ago

Fixed?

ZieIony commented 8 years ago

Almost. Absorb should check for overscroll mode. Glows are initialized when overscroll mode is always || ifContentScrolls. That should fix NPE.

I don't know where's that background issue came from.

Teja-Konjeti commented 8 years ago

May be its not initialized when background is not there. U can check it with my previously uploaded sample nd remember to comment itemDecoration while testing it! :)

ZieIony commented 8 years ago

That was fixed before. Null background was causing draw(Canvas) to be skipped

Teja-Konjeti commented 8 years ago

Ohh.. wait I forgot to setOverScrollMode to always in another fragment which was default in support Library that's why it was null in my case

Teja-Konjeti commented 8 years ago

So there's no background Issue.. My bad, checked it!

ZieIony commented 8 years ago

Another push. Now it works correctly with headers and shouldn't crash.

Teja-Konjeti commented 8 years ago

Yep! Working!

Teja-Konjeti commented 8 years ago

Found another little bug, Pull EdgeEffect fully down, scroll Up the RecyclerView, EdgeEffect decelerates slower than it should be... No one would notice it just thought of informing!

ZieIony commented 5 years ago

Edge effects are copied from the official Android sources, so there shouldn't be any difference. I didn't notice any issues with these effects, so I'm closing this issue.