search

ZiftrCOIN / ziftrcoin

http://www.ziftrcoin.com/
MIT License
10 stars 6 forks source link

New RPC call for total coins #7

Closed scmorse closed 9 years ago

scmorse commented 9 years ago

Total coins rpc call

sjspangenberg commented 9 years ago

Putting code other than macros in header files should be avoided when possible.

sjspangenberg commented 9 years ago

Merged, and commented that one really doesn’t want to be putting code other than macros into header files. The code in the main.h header file is not likely to cause problems because it’s the header for main, but it can make a lot of headaches that can be hard to track down. There’s no way you would know that, having started your C exposure with crypto currency source code, but it’s a habit worth avoiding unless it’s absolutely necessary.

Scott Spangenberg Amherst, NH

On Mar 4, 2015, at 12:10 PM, Stephen notifications@github.com wrote:

Total coins rpc call

You can view, comment on, or merge this pull request online at:

https://github.com/ZiftrCOIN/ziftrcoin/pull/7

Commit Summary

• fix bug in submitting work through getwork • Add new rpc call for coin totals File Changes

• M .gitignore (9) • M src/coins.cpp (1) • M src/main.cpp (15) • M src/main.h (16) • M src/rpcblockchain.cpp (54) • M src/rpcclient.cpp (1) • M src/rpcmining.cpp (4) • M src/rpcserver.cpp (1) • M src/rpcserver.h (3) Patch Links:

• https://github.com/ZiftrCOIN/ziftrcoin/pull/7.patch • https://github.com/ZiftrCOIN/ziftrcoin/pull/7.diff — Reply to this email directly or view it on GitHub.

scmorse commented 9 years ago

I know code should be kept out of header files when possible, I just put declarations and functions that were short, simple and non-changing enough to be inline functions.