ZigRazor / CXXGraph

Header-Only C++ Library for Graph Representation and Algorithms
https://zigrazor.github.io/CXXGraph/
Mozilla Public License 2.0
472 stars 115 forks source link

Bug Fix for #418 - Graph<T>::removeNode has potential to throw due to optional being accessed early #430

Closed Ajay-26 closed 5 months ago

Ajay-26 commented 6 months ago

Pull Request for Bug #418.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.87%. Comparing base (1b31e63) to head (6f4e654). Report is 23 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #430 +/- ## ========================================== + Coverage 97.58% 97.87% +0.29% ========================================== Files 87 87 Lines 9492 10083 +591 Branches 0 666 +666 ========================================== + Hits 9263 9869 +606 + Misses 229 214 -15 ``` | [Flag](https://app.codecov.io/gh/ZigRazor/CXXGraph/pull/430/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ZigRazor) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ZigRazor/CXXGraph/pull/430/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ZigRazor) | `97.87% <100.00%> (+0.29%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ZigRazor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ZigRazor commented 6 months ago

It's ok, we can wait to merge this due to the license change? What do you think @sbaldu @nolankramer ?