Closed badumbatish closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.87%. Comparing base (
1b31e63
) to head (80e69fd
). Report is 25 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We are waiting the re-liensing #427, after that we can merge it!
how should i pass the rest of the tests on ci/cd ? @ZigRazor
how should i pass the rest of the tests on ci/cd ? @ZigRazor
The only one you can pass is the clang format, just formatting with clang. @badumbatish The ore CI/CD should be fix, now aren't working
Fixes Clang's critical bug on the library where we're doing custom shared_ptr comparison with potentially null ptrs.
This will fix #433 but i think what we should also be doing is enforce nullptr safety on these custom operators on shared ptrs
This allows Clang on MacOS to pass all tests.
to == operator in PointerHash()
@ZigRazor would love a review