Ziggeo / ReactNativeSDK

React Native SDK
Apache License 2.0
7 stars 6 forks source link

Usage with Expo #30

Closed guilhermesad closed 2 months ago

guilhermesad commented 5 years ago

Hi there!

I would like to use the Ziggeo React Native SDK with expo: https://expo.io. I see we need to change some specific android/ios files when using the Ziggeo SDK. How would that work with Expo?

Thanks!

3akat commented 5 years ago

Hi @guilhermesad! Will take a look

guilhermesad commented 5 years ago

@3akat thanks

3akat commented 5 years ago

@guilhermesad In short: works fine, just follow the README section :)

I've tried our SDK (tested on Android) with Expo in the following way

So, please try it out, I would be happy to help with any issues on Android side and @alexyats will help with iOs.

guilhermesad commented 5 years ago

thanks @3akat! How do you do steps 2 and 6 though, if Expo doesn't have an android/ folder?

3akat commented 5 years ago

Here is the sample I've tried
https://docs.expo.io/versions/latest/bare/hello-world/
after executing the expo init --template bare-minimum I have the following structure
image
So, there is an android folder. Is it possible we're talking about different frameworks?

guilhermesad commented 5 years ago

thanks @3akat. I was wondering though about the standard installation, not the bare-minimum one. Unless there's a way to take advantages of the expo features on the bare-minimum mode? For example, how would you build a standalone app the expo way? Just setting app.json correctly and running expo build:android doesn't seem to work.

3akat commented 5 years ago

Hi @guilhermesad, I've played a little bit with the Expo, in short: you have to use the bare mode or follow the Detaching to ExpoKit way
https://docs.expo.io/versions/v28.0.0/expokit/detach/

guilhermesad commented 5 years ago

ok, thanks. Any plans in providing a full-compatible with expo version?

3akat commented 5 years ago

Hi @guilhermesad, We estimate the time required for development, as soon as we finish I’ll let you know.

guilhermesad commented 5 years ago

ok thanks!

fractalgelfo commented 4 years ago

bump, any info on the estimated time for dev on this? I want to use ziggeo with a production Expo app that would really suffer from having to be ejected. I may have bandwidth to contribute to making ziggeo fully compatible with expo, and would like to know the estimate of this work's difficulty + any existing progress before I break ground.

3akat commented 4 years ago

Hi @fractalmarc, Unfortunately, we don't have time right now for developing Expo SDK. If you will be able to contribute that'd be awesome! Here are a few links that may be useful https://ziggeo.com/docs/sdks/javascript https://www.npmjs.com/package/expo-camera Please don't hesitate to ask me if you need some additional info.

3akat commented 4 years ago

Hi @fractalmarc, hope you are doing well! Did you have a chance to try to implement ziggeo + expo application for your needs?

fractalgelfo commented 4 years ago

@3akat did not, I use the Expo built in camera stuff with my own uploader for mobile, and use Ziggeo only for the web version of our react native app. Since regular React Ziggeo doesn't work with RN mobile, I created the following npm module: https://www.npmjs.com/package/react-ziggeo-mobile-friendly

My code imports everything from that, and my webpack config (web only) aliases that module to the real react-ziggeo.