Ziggeo / ReactNativeSDK

React Native SDK
Apache License 2.0
7 stars 6 forks source link

Unable to build iOS with version 1.5.0 #65

Closed jessypouliot98 closed 3 years ago

jessypouliot98 commented 3 years ago

I have got this error in the past with another release(s), can't remember which one (maybe 1.4.33 ?)

Here is the "detailed" error from Xcode Screen Shot 2021-08-05 at 1 56 22 PM Screen Shot 2021-08-05 at 1 56 33 PM

package.json

"react": "17.0.1",
"react-native": "^0.64.2",
"react-native-ziggeo-library": "^1.5.0",

Podfile

pod 'iOS-Client-SDK', :git => 'https://github.com/Ziggeo/iOS-Client-SDK.git'

PS: "pod 'ZiggeoRN', :git => 'https://github.com/Ziggeo/ReactNativeSDK.git'" is not used as it causes another error.

jessypouliot98 commented 3 years ago

I have tried

$ cd ios
$ rm -rf build
$ xcodebuild clean

pod install --repo-update

tried reinstalling everything also


Everything looks fine on android

katolykdev commented 3 years ago

@jessypouliot98 ZiggeoRN was already added in package.json. You don't need to add below code in Podfile. pod 'ZiggeoRN', :git => 'https://github.com/Ziggeo/ReactNativeSDK.ZiggeoRN'

Please remove it. We will update readme file for iOS build soon.

1 2 image

jessypouliot98 commented 3 years ago

@katolykdev as described, I already do not have it in my Podfile, I was just referencing it to remind that either the documentation is wrong or something else was wrong. I was able to build with other prior versions, some needed a bit of changes (on 1.4.35, ZiggeoRecorder2 error had to be renamed to ZiggeoRecorder) but this version, 1.5.0, nothing was found on my end to make it work.

This is why I opened the issue.

Package.json "react-native-ziggeo-library": "^1.5.0",

Podfile.lock

PS: I do not understand the last screenshot

here is the snippet from my RCTZiggeoRecorder.m file

while(parentController.presentedViewController && parentController != parentController.presentedViewController) {
    parentController = parentController.presentedViewController;
}
jessypouliot98 commented 3 years ago

@katolykdev Update, I actually just found the fix..

Screen Shot 2021-08-06 at 10 41 14 AM

Add the highlighted line to the package please 🙏

katolykdev commented 3 years ago

Great

jessypouliot98 commented 3 years ago

@katolykdev The problem is still in the package though.. There is a manual fix, but everyone installing the package has to add an import to the file in Xcode