Ziggeo / ReactNativeSDK

React Native SDK
Apache License 2.0
7 stars 6 forks source link

Cannot build iOS with iOS-Client-SDK 1.1.30 #75

Closed jessypouliot98 closed 2 years ago

jessypouliot98 commented 3 years ago

Hey, it's me again..

pod 'iOS-Client-SDK', :git => 'https://github.com/Ziggeo/iOS-Client-SDK.git'

The current latest native code for iOS breaks the package, again...

Current fix:

Change this: pod 'iOS-Client-SDK', :git => 'https://github.com/Ziggeo/iOS-Client-SDK.git'

to this: pod 'iOS-Client-SDK', :git => 'https://github.com/Ziggeo/iOS-Client-SDK.git', :commit => '295f90fc8777ebe63135359e20fa144409d02e54' (downgrade back to "1.1.29" commit)

I wish the iOS-Client-SDK is not a git dependancy but included INSIDE the package. This will allow auto-linking and remove the need to manually add in Podfile, but most importantly prevent any "random" sudden breaking changes..

jessypouliot98 commented 3 years ago

"react-native-ziggeo-library": "^1.5.2",

bobananto24 commented 2 years ago

@jessypouliot98 You are a lifesaver

3akat commented 2 years ago

Closing the issue. @jessypouliot98 please reopen if you need some more help here.