ZiggyCreatures / FusionCache

FusionCache is an easy to use, fast and robust hybrid cache with advanced resiliency features.
MIT License
1.71k stars 90 forks source link

#230 add in TFM's so dependencies can be optimised #231

Closed thompson-tomo closed 5 months ago

thompson-tomo commented 5 months ago

Add in net coreapp 3.1 & net 6 as TFM to a number of projects so that conditions can be placed on the dependencies to removed explicit dependencies on the newer frameworks

Closes #230

jodydonetti commented 5 months ago

I added some comments per-file, but other than that I get the spirit of your PR and I agree: less explicit dependencies for TFMs that do not require them, great!

In case you agree about the changes, let me know if you want to make them yourself or I can do them.

Thanks!

thompson-tomo commented 5 months ago

Happy to make changes @jodydonetti but atm I can't see any proposed changes. Is there a chance you are yet to click finish on your review which publishes the comments?

jodydonetti commented 5 months ago

Happy to make changes @jodydonetti but atm I can't see any proposed changes. Is there a chance you are yet to click finish on your review which publishes the comments?

Yep, I forgot to submit the review, sorry about that 🤦

thompson-tomo commented 5 months ago

No problem. Review Comments have just been published so will look at them shortly & come back/make changes.