ZiggyCreatures / FusionCache

FusionCache is an easy to use, fast and robust hybrid cache with advanced resiliency features.
MIT License
1.9k stars 97 forks source link

[BUG] 🔭 Better OpenTelemetry traces for incoming backplane notifications #253

Closed jodydonetti closed 5 months ago

jodydonetti commented 5 months ago

Describe the bug

Community user @imperugo noticed that when using the backplane with OpenTelemetry traces enabled, all the spans for the notifications incoming via the backplane were put under one single parent span, basically creating a single mega-span "containing" all the others.

Ideally, each span for each notification should be on their own.

To Reproduce

Here's a MRE (Minimal Reproducible Example) of the issue:

Expected behavior

The traces for the backplane notifications incoming should be root and not "under" another one.

Versions

I've encountered this issue on:

Screenshots

image

(Courtesy of user @imperugo , taken in Grafana Tempo)

jodydonetti commented 5 months ago

UPDATE

While fixing this I noticed another couple of things that, if added to the traces, could make the developer experience better:

So yeah, I took this opportunity to make the overall experience better.

jodydonetti commented 5 months ago

Hi all, FusionCache v1.2.0 is out 🥳