search

ZiggyCreatures / FusionCache

FusionCache is an easy to use, fast and robust hybrid cache with advanced resiliency features.
MIT License
1.87k stars 96 forks source link

Adaptive Options Should Be Evaluated On Error #276

Closed cmeyertons closed 3 months ago

cmeyertons commented 3 months ago

Adaptive Options are now being respected before executing failsafe logic to allow for dynamic fail-safe enablement based on exception type.

First commit illustrates the problem (red) Second commit illustrates the solution (green)

I ran all tests in the solution locally (a couple flaked out and succeeded on re-run 🤷 )

image

Please let me know if there's anything you would like me to change - took the liberty of making the adaptive options code sharable to not introduce 4x duplication (vs 2 previously).

cmeyertons commented 3 months ago

@jodydonetti thank you very much for merging! Don't want to be a pest but do you know a timeline when this change would be released?

Not fail-safing on 4xx requests is critical for our go-live in a few weeks.

jodydonetti commented 3 months ago

I should be able to push out a new version this weekend, sounds good?

jodydonetti commented 3 months ago

Hi all, v1.3.0 is out 🥳