ZijieZhaoMMHW / m_mhw1.0

A MATLAB toolbox to detect and analyze marine heatwaves (MHWs).
GNU General Public License v3.0
45 stars 19 forks source link

Results inconsistencies with other implementations #6

Closed mvdh7 closed 5 years ago

mvdh7 commented 5 years ago

For JOSS review

The noted differences in results between the different implementations (MATLAB, Python, R) are worrisome. It's said that this is caused by differences in how the different languages evaluate percentile thresholds, but surely the code could be adapted to enforce consistent calculations? If not, can you demonstrate that this is the only difference between the implementations, and thus prove that no other discrepancies are hiding behind it?

ZijieZhaoMMHW commented 5 years ago

Please see https://github.com/ZijieZhaoMMHW/m_mhw1.0/blob/master/testing/compare_M_R.md