Ziktofel / Archipelago-SC2-data

Map and mod files for Archipelago-SC2
MIT License
1 stars 13 forks source link

Removing deprecated objective functions #204

Closed Gemster312 closed 1 month ago

Gemster312 commented 1 month ago

With all 83 maps updated to use the new Categorization functions, I am removing the old functions to avoid accidental applications of the wrong objectives. This includes:

The meta-function addObjective has also been internalized to ensure it isn't accidentally directly used and users only use the addCategoryObjective options.

Testing

I used the following script to verify no instances of addObjective were in use anymore: find . -type f -name "*MapScript*" -exec grep -l "addObjective" {} + It gave 3 results, but I verified those 3 are for the addObjectiveExtraLine function, and not one of these deprecated functions above.

Then I searched for any instances of showObjective with this: find . -type f -name "*MapScript*" -exec grep -l "showObjective" {} + No results were found.

Everything has been successfully replaced and the deprecated functions have now been removed.