Ziktofel / Archipelago-SC2-data

Map and mod files for Archipelago-SC2
MIT License
1 stars 13 forks source link

Add Tyrannozor Merge and Upgrades for Tyrannozor/Ultralisk from Dehaka Co-op #217

Closed itsjustbones closed 1 month ago

itsjustbones commented 1 month ago

What is this fixing or adding?

Adds Tyrannozor Merge to Ultralisk and Morphling Barrage of Spikes Upgrade for Tyrannozor - Tyrannozors can unleash a Barrage of Spikes, dealing 100 damage to nearby enemy ground and air units. Tyrant's Protection Upgrade for Tyrannozor - Tyrannozors grants nearby friendly units 2 armor. Imapling Strike Upgrade for Ultralisk/Tyrannozor - Ultralisk and Tyrannozor melee attacks have a 20% chance to stun for 2 seconds. Healing Adaption Upgrade for Ultarlisk/Tyrannozor - Ultralisks and Tyrannozors regenerate life quickly when out of combat.

Also, due to command card space, this moves 3 Passive upgrades from Ultralisk command card to behaivor icons, Anabolic Synthesis, Chitinous Plating, Monarch Blades

Tied to https://github.com/Ziktofel/Archipelago/pull/251

SC2_x64_ANCu2cevFd SC2_x64_azEaonTfQx SC2_x64_eOQvYkvuLe SC2_x64_7sIwzgmzlw SC2_x64_GVaXfMIPGx SC2_x64_RWvWdXr1Ja SC2_x64_YNSOzPuTdy SC2_x64_PZJ7EeK9mJ SC2_x64_Ian3e81TIP

Please note that this is my first PR for both SC2 AP and in general, so if I've messed anything up or you have recommendations, please don't hesitate to let me know.

itsjustbones commented 1 month ago

I should have fixed everything mentioned so far in the latest commits.

itsjustbones commented 1 month ago

I've retested to make sure nothing broke as well.

Ziktofel commented 1 month ago

Bug: Air attack sound doesn't play, no unit response sounds

(you might be linking a sound file from a dependency that isn't a dependency of ArchipelagoPlayer)

Ziktofel commented 1 month ago

Fix the following warnings:

[7/26/2024 6:46:55 PM] Warning: XML: StarCraft II\Mods\ArchipelagoPlayer.SC2Mod\Base.SC2Data\GameData\SoundData.xml(11637,5) : Unable to find parent HoS_PrimalAck  Source: Mods/ArchipelagoPlayer.SC2Mod  Scope: CSound
[7/26/2024 6:46:55 PM] Warning: XML: StarCraft II\Mods\ArchipelagoPlayer.SC2Mod\Base.SC2Data\GameData\SoundData.xml(11709,5) : Unable to find parent HoS_PrimalAck  Source: Mods/ArchipelagoPlayer.SC2Mod  Scope: CSound
[7/26/2024 6:46:55 PM] Warning: XML: StarCraft II\Mods\ArchipelagoPlayer.SC2Mod\Base.SC2Data\GameData\SoundData.xml(11743,5) : Unable to find parent HoS_PrimalAck  Source: Mods/ArchipelagoPlayer.SC2Mod  Scope: CSound
[7/26/2024 6:46:55 PM] Warning: XML: StarCraft II\Mods\ArchipelagoPlayer.SC2Mod\Base.SC2Data\GameData\SoundData.xml(11766,5) : Unable to find parent HoS_PrimalAck  Source: Mods/ArchipelagoPlayer.SC2Mod  Scope: CSound
itsjustbones commented 1 month ago

Bug: Air attack sound doesn't play, no unit response sounds

(you might be linking a sound file from a dependency that isn't a dependency of ArchipelagoPlayer)

I did my sound checks on The reckoning, which is a hots map, so I'm guessing that map has the swarm.sc2campaign dependency, but since the mod doesn't, it breaks on other non hots maps. I'll have to upload it separately then.

itsjustbones commented 1 month ago

Sounds should be fixed now

Ziktofel commented 1 month ago

Add

<CActorSplat id="AP_TyrannozorBurrowedSplat" parent="BurrowedSplat" unitName="AP_Tyrannozor"/>

to actors for correct burrow display