Closed MatthewMarinets closed 4 months ago
I want some more reviews from other ppl as I'm not a kivy expert myself
NP: Red on dark grey is a little hard to read/notice; at a glance, I can see in the text box that something's wrong, but I can't actually read the text without focusing. On the mission label tab I don't see the warning at all unless I'm looking for it.
Can it be a shade of yellow/orange/etc instead maybe?
EDIT: For the record, I love everything else about how the warning text shows up. Thank you for adding this, it's an excellent usability feature!
Can it be a shade of yellow/orange/etc instead maybe?
I tried to set the text colour to match the border colour, which I set to be red as that's normally the most attention-grabbing colour and also communicates that something is wrong. I could change just the text colour, but then I'm not sure users would intuitively connect it with the border. I could change both colours to e.g. orange, but I'm not sure we'd actually get that much more contrast.
I think best solution is to give the textbox a background? It's way harder than it has to be in kivy, but I think I know how to do it now.
Another update to up the contrast of the message text:
BTW shouldn't the color of the font on red background be actually white?
See: https://stackoverflow.com/a/69869976 for font/background contrast
BTW shouldn't the color of the font on red background be actually white?
See: https://stackoverflow.com/a/69869976 for font/background contrast
Hmm, here's the comparison picture. I think white text might be a little better?
I calculated the luminance Ys from the linked algorithm to be 0.14, which is on the white side of the threshold value 0.342.
>>> red = 0.82
>>> green = 0.2
>>> rco=0.2126729
>>> gco=0.7151522
>>> trc=2.4
>>> (red**trc)*rco + (green**trc)*gco
0.1471155558724614
From Berserker:
also if you have that massive banner anyway, why not make it do bind("on_click", download_data)?
Sounds like a good idea, though I'm not really inclined to do that in this PR. I think that involves reworking this to be a button instead of a label, and personally as a dev I expect to want to avoid pressing that button.
/download_data
warnings are now colouredWhat is this fixing or adding?
Removed some clutter, and made the important
/download_data
message highlighted in red.How was this tested?
If this makes graphical changes, please attach screenshots.
Old startup:
New startup:
Part 2 -- Added a red border and message to the launcher if maps are out of date
How was this tested?
/downlod_data
. Verified the border / message went away when the download completed