search

ZikunY / CARMA

GWAS genetics Fine-mapping method
GNU General Public License v3.0
20 stars 7 forks source link

Saving Outlier RDS File as RData File #23

Closed mconery closed 6 months ago

mconery commented 6 months ago

Hi Zikun,

I noticed that the code that saves the outlier checking results has a slight error in it. Specifically, the following line is saving an RDS file, but the file extension is for an RData file:

saveRDS(conditional.S.list,file=paste0(output.labels,'/post', label,'','outliers.RData'))

If you try to open the RData objects, they throw an error unless you manually change the extension back to ".rds". This is obviously a minor issue, but it should also be really easy to fix.

Best, Mitch

ZikunY commented 6 months ago

Hi Mitch,

Thank you so much for pointing out the bug here. For unknown reasons, I had been saving ".rds" file with ".RData" extension for so long...... Glad you picked it up here, appreciate for the help.

Best, Zikun