ZiliaAJY / pe

0 stars 0 forks source link

Wrong display of activity bar in opt frame #10

Open ZiliaAJY opened 1 week ago

ZiliaAJY commented 1 week ago

image.png

The activity bar should be cut off when it is returned if one of the conditions are met. The cutoff between the bars are to be joined by the lifeline.

nus-se-bot commented 3 days ago

Team's Response

Thanks for raising this issue. Firstly, keeping the activation bar continuous reflects the consistent flow of the process. It shows that the method remains active throughout the conditional checks, which is accurate as the conditions are evaluated sequentially within a single ongoing operation. Secondly, most of the time, the activation bar remains continuous because the process flows without interruptions. This reflects the typical user experience where inputs are usually valid and the process completes smoothly. This approach does not hinder developers from understanding the process. It is very clear that if the correct conditions are met, the function exits, as indicated by the dotted return call arrow. This visual cue effectively communicates the point where the method stops due to a rare exceptional condition.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]