ZiliaAJY / pe

0 stars 0 forks source link

Unrecognised arrowheads used in class diagrams #9

Open ZiliaAJY opened 6 days ago

ZiliaAJY commented 6 days ago

image.png

For example, the arrow pointing from FilterCommand to UI uses an unrecognised arrowhead. This issue applies to some class diagrams across the developer guide.

nus-pe-script commented 3 days ago

Team's Response

The arrowheads used can be seen used in the cs2113 website, one of it is seen in w8.4 class diagram basics. It follows an extremely similar design (Ours simply are in black colour).

image.png

image.png

The same diagram was reproduced again as an exercise in week 9.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Screenshot 2024-11-16 162143.png

I was referring to this dented arrow that the team used (which I clearly described in the initial description), but they did not address it in their response. The lecture examples that they quoted did not use the dented arrow as well. The dented arrow is not a valid arrow to be used in class diagrams. This is a minor cosmetic issue, but it is still a bug, which cannot be rejected.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]