search

Zilliqa / ZIP

Zilliqa Improvement Proposal
22 stars 6 forks source link

[ZIP-17] Provider API #50

Closed krisboit closed 3 years ago

krisboit commented 3 years ago

Hey,

This is just a first draft of the ZIP, I just put my ideas in words :) still a lot of changes needed.

Let's discuss about this PR in this issue: #51

bb111189 commented 3 years ago

Hi @krisboit I am assigning ZIP-17 to this ZIP

bb111189 commented 3 years ago

Should this ZIP define a list of standard errors in a table format? The following example seems to be sharing the same error code code: -1 message: ACCESS_UNAUTHORIZED code: -1 message: CANCELED_BY_USER

Example: Code Comment
-1 ACCESS_UNAUTHORIZED
-2 CANCELED_BY_USER
-32601 METHOD_NOT_DEFINE
bb111189 commented 3 years ago

Also rename the file to zip-17.md

krisboit commented 3 years ago

Should this ZIP define a list of standard errors in a table format? The following example seems to be sharing the same error code code: -1 message: ACCESS_UNAUTHORIZED code: -1 message: CANCELED_BY_USER

Example:

Code Comment -1 ACCESS_UNAUTHORIZED -2 CANCELED_BY_USER -32601 METHOD_NOT_DEFINE

Yeah, it should be a table. I drafted this as quick as I could just to get your opinion on it.

Regarding the error codes, I was hoping you would help me define them to be on the same pattern as the errors returned by the RPC. I think it's crucial to assign the code so they don't already exist in RPC API and will not be used in future for other kind of errors. So @bb111189 I need your help on this :)

bb111189 commented 3 years ago

Should this ZIP define a list of standard errors in a table format? The following example seems to be sharing the same error code code: -1 message: ACCESS_UNAUTHORIZED code: -1 message: CANCELED_BY_USER Example: Code Comment -1 ACCESS_UNAUTHORIZED -2 CANCELED_BY_USER -32601 METHOD_NOT_DEFINE

Yeah, it should be a table. I drafted this as quick as I could just to get your opinion on it.

Regarding the error codes, I was hoping you would help me define them to be on the same pattern as the errors returned by the RPC. I think it's crucial to assign the code so they don't already exist in RPC API and will not be used in future for other kind of errors. So @bb111189 I need your help on this :)

hey. I can take a stab at it. Can you also give me write access to your branch so that it is easier from my end.

krisboit commented 3 years ago

Should this ZIP define a list of standard errors in a table format? The following example seems to be sharing the same error code code: -1 message: ACCESS_UNAUTHORIZED code: -1 message: CANCELED_BY_USER Example: Code Comment -1 ACCESS_UNAUTHORIZED -2 CANCELED_BY_USER -32601 METHOD_NOT_DEFINE

Yeah, it should be a table. I drafted this as quick as I could just to get your opinion on it. Regarding the error codes, I was hoping you would help me define them to be on the same pattern as the errors returned by the RPC. I think it's crucial to assign the code so they don't already exist in RPC API and will not be used in future for other kind of errors. So @bb111189 I need your help on this :)

hey. I can take a stab at it. Can you also give me write access to your branch so that it is easier from my end.

Sure! I've sent you an invite.