Zilliqa / ZRC

Zilliqa Reference Contracts
MIT License
40 stars 57 forks source link

feat: event for batch ops #137

Closed ghost closed 2 years ago

ghost commented 2 years ago

This PR changes the events of BatchBurn, BatchTransferFrom to include the previous token owner addresses as the following:

In this way, the events can contain more complete and consistent information. It’s because Burn and TransferFrom events provide the previous token owner address.

But this change will increase the gas cost significantly as the following:

N current BatchBurn (cumulative_gas) new BatchBurn (cumulative_gas)
10 766 1074
50 2137 8665
100 3843 29396

It requires proper discussion that it’s worth the cost or it can be implemented better.