search

Zilliqa / ZRC

Zilliqa Reference Contracts
MIT License
40 stars 57 forks source link

ZRC contracts must have unique names for callback transitions #88

Closed anton-trunov closed 2 years ago

anton-trunov commented 3 years ago

For example, the ZRC-1 and ZRC-2 contracts share the same name for a callback, namely TransferSuccessCallBack.

This prevents using both of these ZRCs in one user contract because that forces the user to have two TransferSuccessCallBack transitions with different type signatures.

hicaru commented 3 years ago

one more

bb111189 commented 3 years ago

Considering there is not much NFT available that requires composability with ZRC-2 tokens within the Zilliqa ecosystem, shall we issue a new ZRC-6 and mark ZRC-1 as deprecated standards?

In this new standard, we give new names to the above name

@AmritKumar @anton-trunov @hicaru

anton-trunov commented 3 years ago

@bb111189 I think that's a solid suggestion. Perhaps we should prefix callbacks with the name of a ZRC, e.g. ZRC6_ TransferSuccessCallBack or something like this.

I think @jjcnn had some suggestions too.

bb111189 commented 2 years ago

Resolved in ZRC-6 https://github.com/Zilliqa/ZRC/pull/98