Zilliqa / dev-wallet

Nucleus Wallet is a free, open-source, Zilliqa Testnet Wallet.

https://dev-wallet.zilliqa.com

GNU General Public License v3.0

13 stars 13 forks source link

CI should fail if changelist is invalid #110

Open ghost opened 3 years ago

ghost commented 3 years ago

Description

Currently, CI for PRs passes for changelist which fails for testing or linting or formatting since https://github.com/Zilliqa/nucleus-wallet/pull/108.

e.g. https://github.com/Zilliqa/nucleus-wallet/pull/109

We can keep the review process much easier by noticing the PRs fail early when invalid. Please put back the yarn ci in the CI for PRs as it validates the changelist.

Expected behavior

CI should fail for changelist that fails for testing or linting or formatting.

Annihilatopia commented 3 years ago

it should be a script that the build stage runs instead of adding yarn ci into the travis.yaml to keep it agnostic

ghost commented 3 years ago

It's an another problem to solve I think. We should not create another problem by solving a problem. https://github.com/Zilliqa/nucleus-wallet/pull/109 should fail.

ghost commented 3 years ago

https://app.travis-ci.com/github/Zilliqa/nucleus-wallet/builds/234997797

109 fails as expected but now it takes around 1000% more time just to fail (1 min -> 11 min)

This might slow down the development process.

Can you check this? @joel-zilliqa @charliecys