bid increment for auction hardcoded

Zilliqa / marketplace-contracts

GNU General Public License v3.0

2 stars 4 forks source link

bid increment for auction hardcoded #21

Closed bb111189 closed 2 years ago

bb111189 commented 2 years ago

    (* Calculate min bid *)
    ten_percent = Uint128 1000;
    bid_increment = portion cur_amount ten_percent;
    min_bid = builtin add cur_amount bid_increment;

Bid increment is hardcoded and not well commented

Might be good to let marketplace contract owner set it

ghost commented 2 years ago

sounds good

ghost commented 2 years ago

I've elaborated the bid increment with https://github.com/Zilliqa/marketplace-contracts/commit/e49963448ccb8de6ddd70a3c0cdc620c9e936c50