search

Zilliqa / marketplace-contracts

GNU General Public License v3.0
2 stars 4 forks source link

check fees don't exceed 100% #25

Closed bb111189 closed 2 years ago

bb111189 commented 2 years ago

End transition

        (* Calculate royalty amount *)
        royalty_fee_bps <- & token_address.royalty_fee_bps;
        royalty_amount = portion sale_price royalty_fee_bps;

        (* Calculate service fee *)
        fee_bps <- service_fee_bps;
        service_fee = portion sale_price fee_bps;

        (* Calculate seller profit *)
        profit = builtin sub sale_price royalty_amount;

Check service fees + royalty fees does not exceed 100%

bb111189 commented 2 years ago

royalty or service fees that changed in the midst of auction can cause complication. Better to lock in the rate at Start transitions

ghost commented 2 years ago

royalty or service fees that changed in the midst of auction can cause complication. Better to lock in the rate at Start transitions

For the above, I've created a new issue https://github.com/Zilliqa/marketplace-contracts/issues/28