Zilliqa / marketplace-contracts

GNU General Public License v3.0
2 stars 4 forks source link

[Fixed price contract] Same amount in a buy order replaces previous buy order with same amount #32

Closed RatulSaha closed 2 years ago

RatulSaha commented 2 years ago

Transaction 1: Buy order with 200 ZIL.

Result:

image

Transaction 2: Buy order with 200 ZIL by same wallet.

Result (see the difference in expiration):

image

[Transaction 3](https://devex.zilliqa.com/tx/0x5cb1054ca86cf80ac9feff8e204602714c5c8cfd7dab12c5222e88ca87817053?network=https://dev-api.zilliqa.com: Buy order with 200 ZIL by a different wallet.

Result:

image

Concern: If this is an expected behavior, I could not find that we are giving money back to the previous offerer. Also, since it emits successful events, the indexer sees this as three different buy offers, even though there is only one available in the contract.