[RIAL-787] Collection Max Fee set to 50%

Zilliqa / marketplace-contracts

GNU General Public License v3.0

2 stars 4 forks source link

[RIAL-787] Collection Max Fee set to 50% #61

Closed razill closed 1 year ago

razill commented 1 year ago

Max fee BPS for brand collection set to 50% (5000 BPS)

inamirandaz commented 1 year ago

@razill do we have a test case where the fees amount to >=100%

commission fee is 50%, royalty is 50%, platform fee is 2.5%? -> this should fail
commission fee is 47.5%, royalty is 50%, platform fee is 2.5%? -> this should proceed but seller gets 0ZIL/0ZRC token

razill commented 1 year ago

@razill do we have a test case where the fees amount to >=100%

commission fee is 50%, royalty is 50%, platform fee is 2.5%? -> this should fail

commission fee is 47.5%, royalty is 50%, platform fee is 2.5%? -> this should proceed but seller gets 0ZIL/0ZRC token

@inamirandaz Thanks for the scenarios, will have these test cases added in FixedPrice.