Zilliqa / zilliqa-js

JavaScript SDK for Zilliqa blockchain
https://www.npmjs.com/package/@zilliqa-js/zilliqa
GNU General Public License v3.0
131 stars 74 forks source link

refactor(crypto): use elliptic/lib/elliptic/ec/signature #386

Closed ghost closed 3 years ago

ghost commented 3 years ago

Description

This PR fixes #385.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov-commenter commented 3 years ago

Codecov Report

Merging #386 (ccc8bd4) into dev (5812a8d) will decrease coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #386      +/-   ##
==========================================
- Coverage   80.98%   80.92%   -0.07%     
==========================================
  Files          44       43       -1     
  Lines        1804     1798       -6     
  Branches      329      327       -2     
==========================================
- Hits         1461     1455       -6     
  Misses        342      342              
  Partials        1        1              
Impacted Files Coverage Δ
packages/zilliqa-js-crypto/src/index.ts 100.00% <100.00%> (ø)
packages/zilliqa-js-crypto/src/schnorr.ts 87.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5812a8d...ccc8bd4. Read the comment docs.