Zilliqa / zilliqa-js

JavaScript SDK for Zilliqa blockchain
https://www.npmjs.com/package/@zilliqa-js/zilliqa
GNU General Public License v3.0
131 stars 74 forks source link

fix(core): tx block header type #399

Closed ghost closed 3 years ago

ghost commented 3 years ago

Description

This PR closes #396 by adding the NumPages which was missing. Also it removes Type which shouldn't be included in the header. References:

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov-commenter commented 3 years ago

Codecov Report

Merging #399 (32ac6a6) into dev (0d43bfc) will increase coverage by 0.16%. The diff coverage is n/a.

:exclamation: Current head 32ac6a6 differs from pull request most recent head d596a90. Consider uploading reports for the commit d596a90 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #399      +/-   ##
==========================================
+ Coverage   80.92%   81.08%   +0.16%     
==========================================
  Files          43       43              
  Lines        1798     1898     +100     
  Branches      327      347      +20     
==========================================
+ Hits         1455     1539      +84     
- Misses        342      358      +16     
  Partials        1        1              
Impacted Files Coverage Δ
packages/zilliqa-js-core/src/types.ts 100.00% <ø> (ø)
packages/zilliqa-js-blockchain/src/chain.ts 71.91% <0.00%> (+6.83%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d43bfc...d596a90. Read the comment docs.