Zilliqa / zilliqa-js

JavaScript SDK for Zilliqa blockchain
https://www.npmjs.com/package/@zilliqa-js/zilliqa
GNU General Public License v3.0
131 stars 74 forks source link

refactor: isBlockNumber #405

Closed ghost closed 3 years ago

ghost commented 3 years ago

Description

This PR uses isBlockNumber() to remove redundancy.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov-commenter commented 3 years ago

Codecov Report

Merging #405 (c3794be) into dev (96c014e) will decrease coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head c3794be differs from pull request most recent head f80809a. Consider uploading reports for the commit f80809a to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #405      +/-   ##
==========================================
- Coverage   81.28%   81.27%   -0.02%     
==========================================
  Files          43       43              
  Lines        1811     1810       -1     
  Branches      334      332       -2     
==========================================
- Hits         1472     1471       -1     
  Misses        338      338              
  Partials        1        1              
Impacted Files Coverage Δ
packages/zilliqa-js-blockchain/src/chain.ts 66.83% <100.00%> (-0.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96c014e...f80809a. Read the comment docs.