Zilliqa / zilliqa-js

JavaScript SDK for Zilliqa blockchain
https://www.npmjs.com/package/@zilliqa-js/zilliqa
GNU General Public License v3.0
131 stars 74 forks source link

build: tslib as dependency #406

Closed ghost closed 3 years ago

ghost commented 3 years ago

Description

This PR adds tslib as dependency. As of TypeScript 3.9, tslib version of 2.x is required to build new applications.

The tslib is a runtime library for Typescript. The version of this library is bound to the version of the TypeScript compiler used to compile a library. Peer dependencies do not accurately represent this relationship between the runtime and the compiler. https://angular.io/guide/migration-update-libraries-tslib#why-is-this-migration-necessary

Users have been asked to install tslib since https://github.com/Zilliqa/Zilliqa-JavaScript-Library/pull/169.

yarn add @zilliqa-js/zilliqa
# you may also need to install the tslib package.
yarn add tslib
# bn.js should be added with the above package. if it is not, install it manually.
yarn add bn.js

References:

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov-commenter commented 3 years ago

Codecov Report

Merging #406 (3689d9e) into dev (96c014e) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 3689d9e differs from pull request most recent head 48f49f0. Consider uploading reports for the commit 48f49f0 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #406   +/-   ##
=======================================
  Coverage   81.28%   81.28%           
=======================================
  Files          43       43           
  Lines        1811     1811           
  Branches      334      334           
=======================================
  Hits         1472     1472           
  Misses        338      338           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96c014e...48f49f0. Read the comment docs.