Zilliqa / zilliqa-js

JavaScript SDK for Zilliqa blockchain
https://www.npmjs.com/package/@zilliqa-js/zilliqa
GNU General Public License v3.0
131 stars 74 forks source link

ci: fix tsc check #425

Closed ghost closed 2 years ago

ghost commented 2 years ago

Description

This PR fixes the TSC check in the CI.

For example the TSC check should fail for https://github.com/Zilliqa/Zilliqa-JavaScript-Library/pull/424 which is the initial commit of https://github.com/Zilliqa/Zilliqa-JavaScript-Library/pull/423. The TSC check doesn't fail for it because when the build output is newly published to the local registry, the dependencies were not updated with the new version with --canary.

Therefore, to fix the above issue this PR uses the following:

npx lerna publish patch --registry $local_registry \
--no-verify-access --force-publish=* --no-push \
--ignore-scripts --dist-tag e2e --yes

With this change, we can get the expected result: https://app.travis-ci.com/github/Zilliqa/Zilliqa-JavaScript-Library/builds/241400941#L909-L916.

Also, this PR changes the pre-commit hook to pre-push hook so that the husky hook can be skipped with --no-push.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Merging #425 (3220093) into dev (b973e4d) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 3220093 differs from pull request most recent head 0841f91. Consider uploading reports for the commit 0841f91 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #425   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files          43       43           
  Lines        1811     1811           
  Branches      332      332           
=======================================
  Hits         1488     1488           
  Misses        322      322           
  Partials        1        1           
Impacted Files Coverage Δ
packages/zilliqa-js-crypto/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b973e4d...0841f91. Read the comment docs.