Zilliqa / zilliqa-js

JavaScript SDK for Zilliqa blockchain
https://www.npmjs.com/package/@zilliqa-js/zilliqa
GNU General Public License v3.0
131 stars 74 forks source link

fix: uuid #431

Closed ghost closed 2 years ago

ghost commented 2 years ago

Description

This PR uses import { v4 as uuidv4 } from 'uuid'; Also, it updates @types/uuid to v8.3.1

const uuid = require('uuid'); // <== REMOVED! This usage pattern was already discouraged in uuid@3.x and has been removed in uuid@7.x.

Reference:

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Merging #431 (adcb760) into dev (5788e35) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head adcb760 differs from pull request most recent head 02d3df6. Consider uploading reports for the commit 02d3df6 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #431   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files          44       44           
  Lines        1817     1817           
  Branches      335      335           
=======================================
  Hits         1493     1493           
  Misses        323      323           
  Partials        1        1           
Impacted Files Coverage Δ
packages/zilliqa-js-crypto/src/keystore.ts 92.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5788e35...02d3df6. Read the comment docs.