Zilliqa / zilliqa-js

JavaScript SDK for Zilliqa blockchain
https://www.npmjs.com/package/@zilliqa-js/zilliqa
GNU General Public License v3.0
131 stars 74 forks source link

Undo plagiarism of schnorr module #461

Closed chjj closed 2 years ago

chjj commented 2 years ago

Years ago, zilliqa-js included my schnorr code in its codebase. I have no issues with that as it retained the proper copyright notice and attribution.

Unfortunately, every version of zilliqa-js distributed from c274377 to ed7704d (the current HEAD) is in direct violation of the license for my schnorr project.

c274377 removed the copyright notice after a refactor and rename, and ed7704d illegaly relicensed my code under the GPL3.

This PR adds the proper license and attribution. As the license holder, I refuse to have it relicensed as GPL, so you'll have to figure that out if you want to put your own attribution there.

On the condition that this is merged, you have my word that I will not pursue anything legally, but I would appreciate a public apology, maybe through twitter or some other means.

codecov-commenter commented 2 years ago

Codecov Report

Merging #461 (20a2167) into main (261b993) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   82.00%   82.00%           
=======================================
  Files          44       44           
  Lines        1801     1801           
  Branches      326      326           
=======================================
  Hits         1477     1477           
  Misses        324      324           
Impacted Files Coverage Δ
packages/zilliqa-js-crypto/src/schnorr.ts 87.20% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.