search

Zilliqa / zq2

Zilliqa 2.0 code base
Apache License 2.0
9 stars 0 forks source link

Too fast empty block creation #1118

Closed DrZoltanFazekas closed 2 months ago

DrZoltanFazekas commented 3 months ago

Under yet to be clarified circumstances we're creating empty blocks too fast, without waiting 1 sec for transactions to be added to the mempool.

Here is an example: https://explorer.zq2-prototestnet.zilliqa.com/block/354427 as well as 354428 are empty blocks created at the same time (within 1 sec) as https://explorer.zq2-prototestnet.zilliqa.com/block/354429 which contains 7 transactions.

I suspect the mempool to be non-empty when 354427 an 354428 were created otherwise we would have waited 1 sec before creating those blocks. However, for some reason no transaction from the mempool was added to these two blocks.

Multiple empty blocks within 1 sec was only observed during the tests that involved submitting transactions. Without transactions sent to the network empty blocks are created at a 1 sec block time.

DrZoltanFazekas commented 2 months ago

I repeated the test and still saw cases of empty blocks created within 1s on the proto-testnet, e.g.

5 empty blocks within 1s by same proposer
view blck timestmp proposer                                   gas      txns high_qc
-----------------------------------------------------------------------------------
5174 5172 14:54:33 0x3907d3d5397af065c5c8b8c4389278de28222885 0        0    5173
5175 5173 14:54:33 0x9a21038511f75492bac85e3d6eae5b37c3fbbdca 10089572 1    5174
5176 5174 14:54:34 0x3907d3d5397af065c5c8b8c4389278de28222885 0        0    5175 <--- here
5177 5175 14:54:34 0x3e422c617eb2880f7ac7be512755e0e103bb916b 0        0    5176 <--- here
5178 5176 14:54:34 0x3e422c617eb2880f7ac7be512755e0e103bb916b 0        0    5177 <--- here
5179 5177 14:54:34 0x3e422c617eb2880f7ac7be512755e0e103bb916b 0        0    5178 <--- here
5180 5178 14:54:34 0x3e422c617eb2880f7ac7be512755e0e103bb916b 0        0    5179 <--- here
5181 5179 14:54:35 0x3e422c617eb2880f7ac7be512755e0e103bb916b 69176300 25   5180
5182 5180 14:54:37 0x3907d3d5397af065c5c8b8c4389278de28222885 38738728 14   5181
5183 5181 14:54:38 0x3e422c617eb2880f7ac7be512755e0e103bb916b 0        0    5182

empty blocks within 1s by different proposers
view blck timestmp proposer                                   gas      txns high_qc
-----------------------------------------------------------------------------------
5390 5388 14:58:45 0x9a21038511f75492bac85e3d6eae5b37c3fbbdca 0        0    5389
5391 5389 14:58:46 0x9a21038511f75492bac85e3d6eae5b37c3fbbdca 0        0    5390
5392 5390 14:58:46 0xcca93a2e1169caf02e515203d1539cc3f390890a 10089572 1    5391
5393 5391 14:58:47 0x9a21038511f75492bac85e3d6eae5b37c3fbbdca 5534104  2    5392
5394 5392 14:58:47 0x3e422c617eb2880f7ac7be512755e0e103bb916b 0        0    5393 <--- here
5395 5393 14:58:47 0x9a21038511f75492bac85e3d6eae5b37c3fbbdca 0        0    5394 <--- here
5396 5394 14:58:48 0x9a21038511f75492bac85e3d6eae5b37c3fbbdca 27670520 10   5395
5397 5395 14:58:49 0x3907d3d5397af065c5c8b8c4389278de28222885 16602312 6    5396
5398 5396 14:58:49 0x3e422c617eb2880f7ac7be512755e0e103bb916b 0        0    5397
5399 5397 14:58:50 0xcca93a2e1169caf02e515203d1539cc3f390890a 0        0    5398
5400 5398 14:58:51 0xcca93a2e1169caf02e515203d1539cc3f390890a 83011560 30   5399
5401 5399 14:58:52 0x3907d3d5397af065c5c8b8c4389278de28222885 2767052  1    5400
5402 5400 14:58:53 0x3e422c617eb2880f7ac7be512755e0e103bb916b 0        0    5401

It's not a blocker for Jasper since the transactions are not delayed