Closed DrZoltanFazekas closed 3 days ago
The hardcoded return value of withdrawalPeriod() in https://github.com/Zilliqa/zq2/blob/main/zilliqa/src/contracts/deposit.sol#L588 shall be replaced with an immutable variable set in the constructor based on a consensus setting in the toml file like the minimum_stake, rewards_per_hour etc.
withdrawalPeriod()
minimum_stake
rewards_per_hour
This will enable us to test withdrawals on devnet due to a shorter unbonding period than 2 weeks.
devnet
For now, we agreed on returning a shorter period in the withdrawalPeriod() function if the block.chainid is the devnet
block.chainid
The hardcoded return value of
withdrawalPeriod()
in https://github.com/Zilliqa/zq2/blob/main/zilliqa/src/contracts/deposit.sol#L588 shall be replaced with an immutable variable set in the constructor based on a consensus setting in the toml file like theminimum_stake
,rewards_per_hour
etc.This will enable us to test withdrawals on
devnet
due to a shorter unbonding period than 2 weeks.