search

Zilliqa / zq2

Zilliqa 2.0 code base
Apache License 2.0
9 stars 0 forks source link

Native zil to Native zil Transaction failed - GasPriceLessThanBasefee #818

Closed chetan-zilliqa closed 5 months ago

chetan-zilliqa commented 5 months ago

I sent a payment transaction(native zil to native zil) through a web wallet(zillet.io) and it failed because of an error hash=16ed894488879c0034ff9bcd5be98edfe4807944c4788da1d1d9a28740e9c87c error=Transaction error: GasPriceLessThanBasefee

2024-04-04T10:52:17.254660Z INFO zilliqa::node: 259: seen new txn Zilliqa { tx: TxZilliqa { chain_id: 700, nonce: 1, gas_price: 4761904, gas_limit: 50, to_addr: 0xec31349b7f17ea28ff59c7586c7734be23e43443, amount: 100000000000000, code: "", data: "" }, key: PublicKey { point: AffinePoint { x: FieldElement(FieldElementImpl { value: FieldElement5x52([705178180786072, 3855836460717471, 4089131105950716, 3301581525494108, 133858670344668]), magnitude: 1, normalized: true }), y: FieldElement(FieldElementImpl { value: FieldElement5x52([2199641648059576, 1278080618437060, 3959378566518708, 3455034269351872, 79417610544803]), magnitude: 1, normalized: true }), infinity: 0 } }, sig: ecdsa::Signature<Secp256k1>(61BF6B4E4A9611BA0CBE17BAB82559D0CB44CEAA4879363FDD8B5A58A0E6EED3BEDEB0ED35CD1C1CD0929F7DE4B027E2DF6047844268050B84CE5C53E47EAD9F) } hash=16ed894488879c0034ff9bcd5be98edfe4807944c4788da1d1d9a28740e9c87c 2024-04-04T10:52:17.307751Z INFO zilliqa::consensus: 600: apply rewards in view 741 2024-04-04T10:52:17.371051Z INFO zilliqa::exec: 212: executing txn hash=16ed894488879c0034ff9bcd5be98edfe4807944c4788da1d1d9a28740e9c87c txn=VerifiedTransaction { tx: Zilliqa { tx: TxZilliqa { chain_id: 700, nonce: 1, gas_price: 4761904, gas_limit: 50, to_addr: 0xec31349b7f17ea28ff59c7586c7734be23e43443, amount: 100000000000000, code: "", data: "" }, key: PublicKey { point: AffinePoint { x: FieldElement(FieldElementImpl { value: FieldElement5x52([705178180786072, 3855836460717471, 4089131105950716, 3301581525494108, 133858670344668]), magnitude: 1, normalized: true }), y: FieldElement(FieldElementImpl { value: FieldElement5x52([2199641648059576, 1278080618437060, 3959378566518708, 3455034269351872, 79417610544803]), magnitude: 1, normalized: true }), infinity: 0 } }, sig: ecdsa::Signature<Secp256k1>(61BF6B4E4A9611BA0CBE17BAB82559D0CB44CEAA4879363FDD8B5A58A0E6EED3BEDEB0ED35CD1C1CD0929F7DE4B027E2DF6047844268050B84CE5C53E47EAD9F) }, signer: 0x29e562f73488c8a2bb9dbc5700b361d54b9b0554, hash: 16ed894488879c0034ff9bcd5be98edfe4807944c4788da1d1d9a28740e9c87c } 2024-04-04T10:52:17.371162Z WARN zilliqa::consensus: 655: transaction failed to execute hash=16ed894488879c0034ff9bcd5be98edfe4807944c4788da1d1d9a28740e9c87c error=Transaction error: GasPriceLessThanBasefee

JamesHinshelwood commented 5 months ago

This should be fixed (or at least fixable) once #791 is merged. Currently, basic transfers made through the ZIL API are handled by the EVM. This means the units of gas are wrong. After #791, basic transfers in TxZilliqas will be handled by a separate code path (where we can charge gas in the correct units of Scilla gas rather than EVM gas).

chetan-zilliqa commented 5 months ago

Ok , thanks, I will wait for that. I managed to run the basic performance tests with zq2. For running the conformance tests, do think i should use the branch #791 ?

JamesHinshelwood commented 5 months ago

I think its better to test on main, record what doesn't work and then retest once #791 has landed. #791 still might change before being merged.

chetan-zilliqa commented 5 months ago

understood, thanks

JamesHinshelwood commented 5 months ago

FWIW sending a native transfer on zillet.io against #791 now works.

JamesHinshelwood commented 5 months ago

Will close this because I think its fixed. @chetan-zilliqa please reopen if not.

chetan-zilliqa commented 5 months ago

sorry for the delay in verification. Yes. I tested. It works fine now.