search

Zilliqa / zq2

Zilliqa 2.0 code base
Apache License 2.0
9 stars 0 forks source link

`BlockNumber` parameters in Eth APIs do not respect two-chain finalisation #863

Closed JamesHinshelwood closed 2 months ago

JamesHinshelwood commented 5 months ago

Currently if you pass "finalized" or "safe" for the block number, we just take the block 2 steps away from the latest. This isn't correct.

https://github.com/Zilliqa/zq2/blob/3b3e3981f67bb4213ca8ac716704cf0bceffbb85/zilliqa/src/node.rs#L288

JamesHinshelwood commented 3 months ago

Also consider how to support the require_canonical flag from EIP-1898