search

Zilola-Nazarova / ruby-capstone-project

A console app that allows users to manage collections of their things: books, music albums, and games. The data is be stored in JSON files. Built with Ruby.
3 stars 1 forks source link

Set up Kanban board #25

Closed Zilola-Nazarova closed 1 year ago

Zilola-Nazarova commented 1 year ago

Our Kanban board: https://github.com/Zilola-Nazarova/ruby-capstone-project/projects/1

There are 3 people in our team.

@Zilola-Nazarova assigned to tasks of Team member #1 @GhostEsso assigned to tasks of Team member #2 @hetrox8 assigned to tasks of Team member #3

We do not have Team member #4

topeogunleye commented 1 year ago

Hi @Zilola-Nazarova, @hetrox8, @GhostEsso,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Try-Again

(Highlights) Good Points: 💪

  1. Excellent Setup: Kudos for providing a comprehensive GitHub issue which not only has the link to the GitHub project but also provides the required information such as team member count and their respective GitHub usernames. This facilitates easy tracking and collaboration!

  2. Template Adherence: Your board faithfully mirrors the template provided: Microverse template board. This adherence ensures that the structure and organization are consistent with the expected standards.

  3. Column Consistency: A notable point is that the columns on your Kanban board match precisely with those in the template. This is crucial for ensuring that all stages of task progress are tracked accurately.

  4. Detailed Card Descriptions: It's commendable that every card on your board is detailed with:

    • A descriptive title that gives a snapshot of the task.
    • A prefix indicating the complexity of the task in terms of points. This is vital for time management and task prioritization.
    • A well-outlined description of the task, ensuring that each team member can understand and pick up the task with full clarity.

Overall, your preparation and organization at this initial stage are commendable and set the foundation for a successful project execution!

Required Changes ♻️

Code Review Comment for Kanban Board Setup

Hello! Team👋

Firstly, I commend your effort in setting up the Kanban board. Using a board to track and manage tasks is an excellent practice to ensure that all project requirements are met.

However, after reviewing the board against the listed group tasks and individual tasks, it seems there are discrepancies. Specifically, I observed that some of the cards on the board appear to be based on your interpretations or variations of the requirements rather than direct copies of the given requirements.

For clarity and better tracking, it's crucial to ensure that:

  1. Direct Requirement Mapping: Each requirement listed as a group task or individual task should have a corresponding card that mirrors the exact wording and intent of the original requirement.
  2. Avoid Custom Interpretations: It's essential, especially for collaborative projects, to avoid introducing personal interpretations into task descriptions. This could lead to misunderstandings or misalignments in the project direction.

To remedy this:

  1. Please revisit the provided group tasks and individual tasks.
  2. For each task, create a card on the Kanban board that uses the exact wording of the requirement.
  3. If any of the current cards are based on personal interpretations or additions, reconsider if they are necessary for the project. If they aren't, you might want to remove them to maintain clarity.

Setting up the board in alignment with the provided requirements will ensure that everyone on the team is on the same page and that there's a clear direction for the project.

Kindly observe that each item indicated by the arrow in the image below should have a matching card on the board:

image

Similarly, ensure that each of the individual tasks highlighted in the following image is also represented with its own card: :image

Keep up the effort, and if you have any questions or need further clarity on any point, don't hesitate to ask!

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag @topeogunleye in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

divinecharlotte commented 1 year ago

Hello @Team 😃 🥳 🎉 🎈

Great Job 😄 👏 You've done it. Your project is complete! There is nothing else to say other than... it's time to merge it 👍🏻 ✅

To Highlight 💯

Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.