Zimbra / installguides

Zimbra Installation Guides
https://zimbra.github.io/installguides/
Other
30 stars 22 forks source link

Jorge Review to Languages, and more #19

Closed jorgedlcruz closed 7 years ago

jorgedlcruz commented 7 years ago

Here are all the changes I made for the Install Guides, system requirements, delete the Suse which is deprecated for so long, Languages, and much more.

gordyt commented 7 years ago

@jorgedlcruz I am verifying this with John but I think there may be some additional updates required, similar to the work that John already did here:

bf714a6 [John Eastman] Cleanup in preparation for translations.
Ordered lists have been indented per recommendation from po4a. 
Indentation cleanup of existing lists.

Will let you know what I find out.

jorgedlcruz commented 7 years ago

Okay @gordyt please let me know, the edits were so extensive across the whole document. We are aiming to have this as /latest as discussed before. Let me know the edits we should add as well. Or maybe we can merge this and then do the additional changes after.

gordyt commented 7 years ago

Will do. I believe that we will want to make these changes first. If I understand the issue correctly, there are some problems generating the files required to do language translation without them.

BTW, is OK for now, but for future PRs please base them off of the develop branch. Note that I did do the whole latest thing yesterday (for admin and install guides), and is very easy to update after we merge your PR.

gordyt commented 7 years ago

@jorgedlcruz let me go ahead and generate a test export so folks can see the final product. One sec...

jorgedlcruz commented 7 years ago

Appreciated @gordyt thank you as usual for all the hard work!

gordyt commented 7 years ago

@jorgedlcruz I had to push in one fix to your branch for this:

$ asciidoctor -b html5 -o single.html index-single-server-install.adoc
asciidoctor: WARNING: installing.adoc: line 330: list item index: expected 15, got 16
asciidoctor: WARNING: installing.adoc: line 338: list item index: expected 16, got 17
asciidoctor: WARNING: installing.adoc: line 349: list item index: expected 17, got 18

Generated a gh-pages export with the results. You can view them here:

Please go through the results and check the formatting.

gordyt commented 7 years ago

@jorgedlcruz I'm adding @gaylebillat as a content reviewer.

jorgedlcruz commented 7 years ago

So now with all the suggested changes, @gordyt do you think you can generate another HTML, which I hope is the final version, for now at least?

gordyt commented 7 years ago

@jorgedlcruz will do. Gotta finish a few things first. Will post update here when live.

gordyt commented 7 years ago

@jorgedlcruz I have redone the export and went ahead and published it to the 8.8.3 (latest) location.

If you do have to make any additional changes, please be sure and update your local jorge-review branch with the latest copy of it from origin. You had inadvertently done a merge from origin/jorge-review to your local jorge-review (rather than rebasing your local jorge-review onto origin/jorge-review) and ended up with a wonky merge commit.

For example, you would do the following from your local checkout:

git fetch origin
git checkout -B jorge-review origin/jorge-review

That will reset your local branch to be correctly in sync with origin.