Zingabopp / BeatSync

Beat Saber plugin to automatically download beatmaps.
Other
246 stars 22 forks source link

don't use working directory for config/logs #21

Closed ashkitten closed 4 years ago

ashkitten commented 4 years ago

at the moment, BeatSyncConsole uses files inside the current working directory, which is problematic as i want to add the executable to my PATH so i can run it from anywhere. as is, depending on where i run it from, it won't pick up the existing config and will litter the current directory with configs, logs, and Temp

on linux it should probably use a folder according to the XDG standard (usually under ~/.config) for the configs and logs directories, and assuming Temp is what it says, it can use mktemp to have the system create a temporary directory for it.

Zingabopp commented 4 years ago

See if this works to your satisfaction: https://github.com/Zingabopp/BeatSync/actions/runs/195889592

ashkitten commented 4 years ago

having configs and logs next to the assembly won't work for me specifically since i'm actually building and installing the program myself with nix (https://github.com/ashkitten/nixos-config/blob/master/packages/BeatSyncConsole/default.nix). a cli option or environment variable to specify the config/log directories would work, since i can just add it to the wrapper... but it would certainly be nice to just use xdg dirs like QBeat does

Zingabopp commented 4 years ago

CLI options for config/log directories added.

ashkitten commented 4 years ago

that works for me, thanks

Zingabopp commented 4 years ago

Official release: https://github.com/Zingabopp/BeatSync/releases/tag/0.9.0