Closed margaretdax closed 10 years ago
For a long time I thought I wouldn't be adding support for ST3, but since the new ST3 Beta is now public, I might just do it. Most compatibility issues come from the change to the print function from python 2 to 3, but it shouldn't be a big problem to fix these. But it might be that the ST api got some changes, so it would be hard to make the plugin be compatible for different apis.
When I find some time, I'll have a look into this.
I tried it out, but there seem to be many problems going on.
The basics steps are: replace print something to print(something) replace except Error, e to except Error as e replace import SomeUnrealScriptIDEModule to import UnrealScriptIDE.SomeUnrealScriptIDEModule
Those are the simple things to fix, and that way some parts would already run, however most wouldn't. There seem to be many problems with the threading module, but I really don't have the time to investigate those.
You're of course free to try to port it by yourself.
So I won't try to port it in the near future, but I might have a look at it again when ST3 if officially released.
Best regards, Zinggi
I don't really have the time to, but good to hear it might be ported after ST3 officially releases.
Thanks :)
How difficult do you think it would be to port this to ST3 if a few of us contribute? I'm willing to help in the near future if I can.
It shouldn't be too difficult, it's probably just a matter of adding some:
try:
import blabla
except ImportError:
import UnrealScriptIDE.blabla
At the top and replacing some print statements. But I'd have to read through some other plugins that support both version to see what the best practise is and how they deal with different versions.
You're of course welcome to help, just fork this repo and send me a pull request if you have made some useful changes.
I like this one better:
ST3 = int(sublime.version()) > 3000
if ST3:
import ...
else:
import ....
Cool. I'll look into it when I have some free time in the coming weeks. :)
Would be supercool!
I took some time over this weekend to port it over to ST3.
Everything is working pretty good, however there is a major bug that prevents me from releasing this to the public yet: https://github.com/Zinggi/UnrealScriptIDE/issues/21 If anyone of you could help find the issue, that would be awesome. Also, can you confirm that this bug is also happening on your pc and not only on mine?
Also, before I release the update, I have to make sure I haven't broken anything in ST2..
Thanks for your help!
Here's the ST3 branch: https://github.com/Zinggi/UnrealScriptIDE/tree/ST3
Alright, that's fixed, gonna merge the ST3 branch soo.
Hope I didn't introduce any bugs ;)
This is the log I get when I try to install your package under ST3