Zinggi
commented
11 years ago Hey Allar,
Thank you really much for trying to contribute to this project. I haven't gotten around yet to read and review all your changes, but I'm going to do that soon. One thing I don't like about your implementation for local variable support is that it's basically wasting a lot of memory for local variables where you don't need them. The only place where you would need local variable completions is in the current function you're just writing. So I would prefer a different implementation, as memory is an issue if you have many files opened. As a solution, I have thought of something like a live parsing of just the current file, but I'm not exactly sure yet how that's going to work.
Another problem is that the code that's online here and the code that's on my pc is completely different now, as I've rewritten and restructured many things over this weekend. I will soon upload a big update, so that you can see the new code which is now much better structured and more functional.
For the reasons above I can't merge this yet, but I'll definitely try to include this in an upcoming release.
Thanks again for your commitment, Zinggi
Allar
Been looking at this for awhile, decided to try it out, was saddened to find class member auto-completion but no local auto-completion but love what has been done so far, so I went ahead and added it.
My Python is a little rusty, and the ST2 API documentation is really lacking to me, but maybe this is helpful? Its helpful to me :D
I tried adding conforming code and comments according to the current style, if there are any stylisic errors, please point them out and I'll be glad to conform.
Thanks Zinggi for getting what has been done done so far and putting it out for the public!