search

ZionDevelopers / playx

In-game Internet (YouTube, Twitch, SoundCloud, mp4 and etc.) media player for Garry's Mod
http://steamcommunity.com/sharedfiles/filedetails/?id=106516163
Other
18 stars 14 forks source link

Opening certain URLs in non-browsable provider and then closing causes a hard CTD for all clients #105

Closed Krylia closed 1 year ago

Krylia commented 7 years ago

I'm not gonna give any example URL's here. Go experiment. Plenty of URL's do this shit.

Adam759 commented 7 years ago

I will definitely look into this. A lot of stuff is changing right now so things may become slightly unstable. Thank you for reporting

Adam759 commented 7 years ago

You are going to have to give me at least one example URL here because I just tested over 20 URL's by opening them with non-browsable webpage and then closing them with the close media button and none of them crashed my client or any other clients on the server. I will continue to test but more information would be beneficial.

Adam759 commented 7 years ago

Upon further testing, I could get it to happen if a file were to be opened with the non-browsable webpage provider, such as https://drive.google.com/uc?export=download&id=0B0JMGMGgxp9WMEdWb1hyQUhlOWs . (This link points to a google drive video download source). I will look into why that is happening. I am aware that there are some issues surrounding google drive right now as well and I am looking into that as well.

Krylia commented 7 years ago

It also occurs with some file links that are non-google drive related. Despite the following link being rather... unsavory... it does reproduce the issue: http://2girls1cup.ca/wp-content/uploads/2015/03/2girls1cupvideo.mp4?_=1

I cannot recall if the crash occured with or without the =1, but, either way, there you go. Another URL that results in a crash.

Adam759 commented 6 years ago

This issue has resurfaced again and will need more investigation. Seems to happen with raw file input or with attempted playback with JWPlayer of .mp4 content, even in Awesomium. The browser seems to hang up, may be an internal issue that is not directly related to our player.