ZionDevelopers / playx

In-game Internet (YouTube, Twitch, SoundCloud, mp4 and etc.) media player for Garry's Mod
http://steamcommunity.com/sharedfiles/filedetails/?id=106516163
Other
18 stars 14 forks source link

Navigator stopped working #124

Closed juliocoliveira closed 1 year ago

juliocoliveira commented 3 years ago

For some reason the navigator are not working anymore, its not showing the changed url on the textbox and the video detection, closing, and playing on PlayX are not working either. There is no errors to try to find what is the issue.

Need to do some testing and investigation, probably garry did some breakage there.

juliocoliveira commented 1 year ago

So, Sam's Media Player, is also broken, with the exact bug. Can someone do some investigating?

TR094 commented 1 year ago

it seems like when you frist spawn a media player it doesnt work. tho if u remove it and spawn it again it seems that it does work.

TR094 commented 1 year ago

update: ok now this is strange... on sam's media player it seemed that the navigator worked normall on without the cefcodecfix. but after i got it installed again not it doesnt seem to work at all? like i can launch the navigator yes, but it doesnt change the url's on the top.

juliocoliveira commented 1 year ago

Yeah, probably is a CEF Codec Fix bug, try to remove the code fix, very integrity of gmod and see if PlayX's navigator and Sam's media player works, if does not, then garry broke it, If it does, so is a CEF Codec Fix bug and you can send a issue on their page, so it gets fixed, I'll keep the fix because of Twitch, so we have to wait to see.

TR094 commented 1 year ago

ok ive gotten the hang of it, its not cefcodecfix its the actual media player that has the problem. it still doesnt show anything even without the cefcodecfix. it seems that the navigator only works like 10% of the time. (oh yeah playx navigator still doesnt work)

juliocoliveira commented 1 year ago

OK, So it's garry's breakage there, Maybe it changed some hooks or GUI classes, I really don't know what is the issue to be exact, need somebody with a lot of Garry's Mod's Lua knowledge to fix this, I'm a bit rusty when it comes to Gmod Lua new features and stuff, So cannot fix it by myself.

TR094 commented 1 year ago

oh yeah how did the navigator even work back then? is it like media player where u click on a youtube video and then click ''request url''?

juliocoliveira commented 1 year ago

It only worked for YouTube and It did automatically, It showed the URL in the box, if it matched with a youtube video it closed the navigator and played the video in the PlayX entity's player. Worked great, but it needs some improvement, like disable the automatic play to put a button to request the video play, and need to work with each provider, and change the default homepage to https://ziondevelopers.github.io/playx/ , like Sam's Media Player, and that's a lot of work. I don't remember much of Gmod's Lua, so need to study and understand how to do that.

Anybody who wants to do that and help us would improve PlayX greatly.

TR094 commented 1 year ago

i found someone else made a navigator that works flawlessly, now i just need to make it work with playx

TR094 commented 1 year ago

i could provide you the code and you could try to integrate it yourself