search

ZionDevelopers / playx

In-game Internet (YouTube, Twitch, SoundCloud, mp4 and etc.) media player for Garry's Mod
http://steamcommunity.com/sharedfiles/filedetails/?id=106516163
Other
18 stars 14 forks source link

Bug fixes and new notification to show who played a video. #74

Closed thegrb93 closed 9 years ago

juliocoliveira commented 9 years ago

There is no errors relating to IsValid since is global function. Thanks but is really useless this commit, But what counts is the intention

thegrb93 commented 9 years ago

playx:IsValid() will error if playx is nil which does happen. If you won't fix the errors then this repository is useless.

juliocoliveira commented 9 years ago

I fix the errors that is reported. As i said i never got that error and nobody ever reported that.

juliocoliveira commented 9 years ago

I'm sorry man, I was arrogant saying that your Pull/Commit was useless, But was true i never got an error report about that, And i didn't played Garry's Mod so i never stopped to test the latest Garry's Mod updates.

Just 12 days ago i got the error report: https://github.com/ZionDevelopers/playx/issues/76

I posted your updates and gave credit to you: https://github.com/ZionDevelopers/playx/commit/bc9fd2cf6fe318063f4292091cfd3d9d9a077458