search

ZipCPU / wb2axip

Bus bridges and other odds and ends
495 stars 100 forks source link

Fix empty statement in sequential block warning #17

Closed d953i closed 4 years ago

d953i commented 4 years ago

Delete extra semicolon.

ZipCPU commented 4 years ago

Looking over your proposed changes, I like the removal of the pair of semicolons. Thanks for catching that! I'm running regression tests on that change now, but don't foresee any problems to accepting that change.

As for the second change request, I'm going to say, no thanks. localparam has been around for over ten years. It's been around long enough that it is supported by open source synthesis tools such as yosys, even when using ISE as a back end, and so using it shouldn't be a problem with any synthesis tool that I am aware of.

d953i commented 4 years ago

Heh. Looks like Github just combined 2 commits to 1 pull request - I actually didn't intent to submit second one. Sorry.

localparam's can't be used for module port in Vivado project mode/block diagram even thou synth have no problem synthesizing it. Not a big deal. localparam_warning

ZipCPU commented 4 years ago

Wait, seriously??? Vivado won't accept it?

Can you tell me which Vivado version you tried this with?

d953i commented 4 years ago

Vivado 2019.2 But then again - only in project/block diagram mode.