ZipRecruiter / cloudwatching

Apache License 2.0
8 stars 7 forks source link

aws_tag_select option #7

Open bheight-Zymergen opened 4 years ago

bheight-Zymergen commented 4 years ago

I was curious if there is any plan to add the aws_tag_select option that was recently introduced to the official cloudwatch exporter?

I tried to take a swing at it myself, but ended up hitting a road block or two on the implementation.

frioux commented 4 years ago

I haven't heard of that! Can you link to the feature or the announcement or something?

-- Sent from a rotary phone rented from Ma Bell

On Thu, Dec 12, 2019, 5:05 PM bheight-Zymergen notifications@github.com wrote:

I was curious if there is any plan to add the aws_tag_select option that was recently introduced to the official cloudwatch exporter?

I tried to take a swing at it myself, but ended up hitting a road block or two on the implementation.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ZipRecruiter/cloudwatching/issues/7?email_source=notifications&email_token=AAAB7Y7WEMEJBMXTXHMOXKDQYLNW7A5CNFSM4J2GPA3KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IAGOY3Q, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAB7Y36Z2RJS6GOCQUIQWLQYLNW7ANCNFSM4J2GPA3A .

bheight-Zymergen commented 4 years ago

Here is the feature implementation PR. https://github.com/prometheus/cloudwatch_exporter/pull/229 https://github.com/prometheus/cloudwatch_exporter/commit/a41ff9a92552ddd195f1fdb9e7b089a2ee117d96

I'd love to help get this implemented

bheight-Zymergen commented 4 years ago

Here is some initial code that I put together on a branch for a way to get the tags.

It's not an implementation on how to do this (and in fact some of it is outright wrong), but it does provide a means of pulling all the tag data down based on the namespace (minus auto scaling groups).

https://github.com/ZipRecruiter/cloudwatching/compare/master...bheight-Zymergen:add_tags