search

Zipstack / unstract

No-code LLM Platform to launch APIs and ETL Pipelines to structure unstructured documents
https://unstract.com
GNU Affero General Public License v3.0
882 stars 54 forks source link

[FIX] Changing env to mountable path - PRIVATE_REGISTRY_CREDENTIAL_PATH #292

Closed harini-venkataraman closed 3 months ago

harini-venkataraman commented 4 months ago

What

Initally the credentials for authenticating private images were directly set to the env variable. This PR changes to a mountable path. ...

Why

This change helps automating On-prem deployents ...

How

Introducing PRIVATE_REGISTRY_CREDENTIAL_PATH for uploading the mount path.

...

Can this PR break any existing features. If yes please list of possible items. If no please exaplin why. (PS: Admins do not merge the PR without this section filled)

This PR will not break existing features. It introduces an env, where the path of SA Key file is mounted. If the file is not present, but the env is set - We do not raise exception rather catch and log. This would prevent the constructor from failing in cases where the private tool is not used.

...

Database Migrations

Not applicable

...

Env Config

PRIVATE_REGISTRY_CREDENTIAL_PATH - Path where the credential file is mounted.

...

Relevant Docs

Not applicable

...

Checklist

I have read and understood the [Contribution Guidelines]().

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

harini-venkataraman commented 3 months ago

Also, do we need any docker-compose file changes for mounting the file?

@ritwik-g You have any comments to add here ?

gaya3-zipstack commented 3 months ago

@harini-venkataraman @nehabagdia I have approved the PR. However I and Harini discussed a few points in propagating this error to the end user in a readable and meaningful way. @harini-venkataraman mentioned that she will address it once @muhammad-ali-e 's work gets merged.

harini-venkataraman commented 3 months ago

@harini-venkataraman @nehabagdia I have approved the PR. However I and Harini discussed a few points in propagating this error to the end user in a readable and meaningful way. @harini-venkataraman mentioned that she will address it once @muhammad-ali-e 's work gets merged.

@gaya3-zipstack @nehabagdia Have raised a issue to track the same https://zipstack.atlassian.net/browse/UN-1214