Fix/write-db-connector-error-handling - Githubissues

Zipstack / unstract

No-code LLM Platform to launch APIs and ETL Pipelines to structure unstructured documents

https://unstract.com

GNU Affero General Public License v3.0

373 stars 31 forks source link

Fix/write-db-connector-error-handling #330

Closed kirtimanmishrazipstack closed 1 month ago

kirtimanmishrazipstack commented 2 months ago

What

Modified database insert query as parameterized query to fix the insert operation
Error handling on db connector
Unit test cases for error handling on db connector

Why

Db connector error was breaking

How

Changes db_utils to insert query as parameterized query
Write uni test cases for creating and inserting table

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

No breaking changes. Changes are in db_utils insert query function which will solve error handling part

Database Migrations

N/A

Env Config

test.env

Relevant Docs

-

Related Issues or PRs

-

Dependencies Versions

-

Notes on Testing

Unit test cases for create/insert db connector
Verified the changes on UI

Screenshots

Screenshot from 2024-05-31 10-16-17 Screenshot from 2024-05-28 18-36-12

Checklist

I have read and understood the [Contribution Guidelines]().

muhammad-ali-e commented 1 month ago

@kirtimanmishrazipstack Please Fix Sonar issue before Merge

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud