To avoid some duplicate code which reduced the amount of code. Being done as a prep before k8s worker interface creation.
How
We had literally same logic used in multiple places. Combined it in to a single method.
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Ideally it shouldn't since we are recreating the exact same logic. If there is a logical error then there is a chance for breakage.
Database Migrations
None
Env Config
None
Relevant Docs
-
Related Issues or PRs
-
Dependencies Versions
-
Notes on Testing
I was able to run the worker locally and do some executions. But couldn't find the actual usage of the portion of code which I changed. Due this I couldn't test it.
Screenshots
Checklist
I have read and understood the [Contribution Guidelines]().
What
Why
How
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
-
Related Issues or PRs
-
Dependencies Versions
-
Notes on Testing
Screenshots
Checklist
I have read and understood the [Contribution Guidelines]().